[llvm] 9ea9e71 - [TargetLowering] Remove comment above definition of TargetLowering::EmitInstrWithCustomInserter. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 29 13:06:27 PDT 2024


Author: Craig Topper
Date: 2024-06-29T13:00:23-07:00
New Revision: 9ea9e71f2e14e1fc8247349ab5dcfa8cc5a639c8

URL: https://github.com/llvm/llvm-project/commit/9ea9e71f2e14e1fc8247349ab5dcfa8cc5a639c8
DIFF: https://github.com/llvm/llvm-project/commit/9ea9e71f2e14e1fc8247349ab5dcfa8cc5a639c8.diff

LOG: [TargetLowering] Remove comment above definition of TargetLowering::EmitInstrWithCustomInserter. NFC

This duplicates the documentation from the declaration, but has
gotten out of sync. There was a mention of a DenseMap that has
been gone for 14 years. Since this declaration is a default
implementation of a virtual function, its unlikely to be looked at.
Just remove it.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
index 1e54af2f098ef..8ce6dfc1fdd26 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -311,15 +311,6 @@ namespace llvm {
 
 } // end namespace llvm
 
-// EmitInstrWithCustomInserter - This method should be implemented by targets
-// that mark instructions with the 'usesCustomInserter' flag.  These
-// instructions are special in various ways, which require special support to
-// insert.  The specified MachineInstr is created but not inserted into any
-// basic blocks, and this method is called to expand it into a sequence of
-// instructions, potentially also creating new basic blocks and control flow.
-// When new basic blocks are inserted and the edges from MBB to its successors
-// are modified, the method should insert pairs of <OldSucc, NewSucc> into the
-// DenseMap.
 MachineBasicBlock *
 TargetLowering::EmitInstrWithCustomInserter(MachineInstr &MI,
                                             MachineBasicBlock *MBB) const {


        


More information about the llvm-commits mailing list