[llvm] [IR] Remove non-canonical matchings (PR #96763)

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 29 09:00:12 PDT 2024


https://github.com/RKSimon commented:

What are you trying to accomplish with this patch? The SLSR change looks sensible, we use the m_c_Add/m_c_Or matchers to avoid duplication in commutative ops. But what are you trying to avoid with the other changes? Are you certain that we won't see constants on the LHS on the ADD/AND ops? Canonicalization isn't always done in time - especially in general code like getKnownBitsFromAndXorOr.

https://github.com/llvm/llvm-project/pull/96763


More information about the llvm-commits mailing list