[llvm] [AArch64][BOLT] Ensure tentative code layout for cold BBs runs. (PR #96609)

Pavel Samolysov via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 29 06:36:10 PDT 2024


================
@@ -382,6 +385,11 @@ uint64_t LongJmpPass::tentativeLayoutRelocMode(
     DotAddress += Func->estimateConstantIslandSize();
     ++CurrentIndex;
   }
+  if (!ColdLayoutDone) {
----------------
samolisov wrote:

I see, you have added a test to check-*not* for the error message. Would you like to add a test to check what happens when the error occurs? This is may be a big issue to reproduce such scenario in a unit test because, as I get, a large application is needed so that this is only a nit.

https://github.com/llvm/llvm-project/pull/96609


More information about the llvm-commits mailing list