[llvm] [AsmPrinter] Reduce AsmPrinterHandlers virt. fn calls (PR #96785)
Jameson Nash via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 13:28:28 PDT 2024
================
@@ -382,13 +382,10 @@ class AsmPrinterHandlerTest : public AsmPrinterFixtureBase {
public:
TestHandler(AsmPrinterHandlerTest &Test) : Test(Test) {}
virtual ~TestHandler() {}
- virtual void setSymbolSize(const MCSymbol *Sym, uint64_t Size) override {}
virtual void beginModule(Module *M) override { Test.BeginCount++; }
virtual void endModule() override { Test.EndCount++; }
virtual void beginFunction(const MachineFunction *MF) override {}
virtual void endFunction(const MachineFunction *MF) override {}
- virtual void beginInstruction(const MachineInstr *MI) override {}
----------------
vtjnash wrote:
Instruction count may only have a weak correlation with wall time though, since instructions take vastly different times to retire, while your comment above seemed to show that this PR made everything measured at 0.5% slower (https://github.com/llvm/llvm-project/pull/96785#issuecomment-2193989698) if I am reading that right. I assume that is well within the noise factor, so not a blocker from me.
`addDebugHandler` looks good for me, but might need a new test here?
https://github.com/llvm/llvm-project/pull/96785
More information about the llvm-commits
mailing list