[llvm] Add ConstantRangeList::subtract(ConstantRange) (PR #97093)
Jan Voung via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 12:28:43 PDT 2024
================
@@ -72,6 +72,12 @@ class [[nodiscard]] ConstantRangeList {
APInt(64, Upper, /*isSigned=*/true)));
}
+ void subtract(const ConstantRange &SubRange);
+ void subtract(int64_t Lower, int64_t Upper) {
----------------
jvoung wrote:
Is this mostly to simplify the test (line 121 in the test.cpp?)?
It might be better to put this logic in the test file instead (could be inlined into the line 121 area?), so that there is (a) smaller public API (b) less int64_t specific APIs (while the rest seem to be more generic regarding bitwidth)?
https://github.com/llvm/llvm-project/pull/97093
More information about the llvm-commits
mailing list