[llvm] [GOFF] Refactor writing GOFF records (PR #93855)

Kevin P. Neal via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 12:13:45 PDT 2024


================
@@ -0,0 +1,22 @@
+# RUN: yaml2obj %s | od -v -An -tx1 | FileCheck --ignore-case %s
+
+## Verify that the GOFF end record is correct, with all fields having a value.
----------------
kpneal wrote:

Can you change this to state that we're verifying that all fields have the value we expect but that the GOFF is still invalid? We have a lot of developers who don't know GOFF and stating that the record "is correct" won't be helpful to them.

https://github.com/llvm/llvm-project/pull/93855


More information about the llvm-commits mailing list