[llvm] [Offload] Refactor offload test requirements (PR #95196)

Ethan Luis McDonough via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 10:35:30 PDT 2024


================
@@ -2,7 +2,7 @@
 // RUN: %libomptarget-run-generic %fcheck-generic
 
 // REQURIES: gpu
-// UNSUPPORTED: nvidia-gpu
+// UNSUPPORTED: nvidiagpu
 // UNSUPPORTED: amdgcn-amd-amdhsa
----------------
EthanLuisMcDonough wrote:

bug49334.cpp is another test case where I did this. I wasn't sure which targets the test was meant to support, so I just kept in a lot of the unsupported directives.

Upstream main:
https://github.com/llvm/llvm-project/blob/aa9bf71ca4eac50f4dfad9bb7b302491265cb889/offload/test/offloading/bug49334.cpp#L8-L16

My PR:
https://github.com/llvm/llvm-project/blob/88b8437ccfe02e9c4911610d3bcc31985f345918/offload/test/offloading/bug49334.cpp#L8-L11

Are these tests meant to be disabled?

https://github.com/llvm/llvm-project/pull/95196


More information about the llvm-commits mailing list