[clang] [llvm] [PAC][ELF][AArch64] Encode signed GOT flag in PAuth core info (PR #96159)

[Daniil Kovalev via llvm-commits]

kovdan01 wrote:

> I was referring to this line from the description:
> 
> > llvm-readobj: print `PointerAuthELFGOT` or `!PointerAuthELFGOT` in version description of llvm_linux platform depending on whether the flag is set.
> 
> In my opinion, if you don't test the first of those two cases, you might as well not have implemented behaviour for it. I'd always test "all flags set" and "no flags set" cases (or some variant that effectively tests this, e.g. 0xff and ~0xff). Of course, if it's not practical, that's fine.
> 
> To be clear, I'm not suggesting testing every possible combination of flags, just each flag individually set/not set.

@jh7370 Thanks for explanation! It's a reasonable point, I'll add corresponding test cases, thanks.

https://github.com/llvm/llvm-project/pull/96159