[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:48:04 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-win` running on `as-worker-93` while building `llvm` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/14/builds/163

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
[1555/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveRangeCalc.cpp.obj
[1556/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveIntervals.cpp.obj
[1557/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveStacks.cpp.obj
[1558/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveVariables.cpp.obj
[1559/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LoopTraversal.cpp.obj
[1560/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBranchProbabilityInfo.cpp.obj
[1561/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LocalStackSlotAllocation.cpp.obj
[1562/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LowerEmuTLS.cpp.obj
[1563/3844] Building X86GenFoldTables.inc...
[1564/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.obj 
C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DEXPENSIVE_CHECKS -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_DEBUG -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\a\llvm-clang-x86_64-expensive-checks-win\build\lib\CodeGen -IC:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\lib\CodeGen -IC:\a\llvm-clang-x86_64-expensive-checks-win\build\include -IC:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Ob0 /Od /RTC1 -std:c++17 -MDd -Zi  /EHs-c- /GR- /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\lib\CodeGen\MachineBlockPlacement.cpp
C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1565/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockFrequencyInfo.cpp.obj
[1566/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCFGPrinter.cpp.obj
[1567/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.obj 
C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DEXPENSIVE_CHECKS -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_DEBUG -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\a\llvm-clang-x86_64-expensive-checks-win\build\lib\CodeGen -IC:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\lib\CodeGen -IC:\a\llvm-clang-x86_64-expensive-checks-win\build\include -IC:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Ob0 /Od /RTC1 -std:c++17 -MDd -Zi  /EHs-c- /GR- /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\lib\CodeGen\MachineDomTreeUpdater.cpp
C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\a\llvm-clang-x86_64-expensive-checks-win\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1568/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCopyPropagation.cpp.obj
[1569/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCombiner.cpp.obj
[1570/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominanceFrontier.cpp.obj
[1571/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCheckDebugify.cpp.obj
[1572/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCycleAnalysis.cpp.obj
[1573/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineConvergenceVerifier.cpp.obj
[1574/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCSE.cpp.obj
[1575/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominators.cpp.obj
[1576/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBasicBlock.cpp.obj
[1577/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPrinterPass.cpp.obj
[1578/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFrameInfo.cpp.obj
[1579/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMTargetMachine.cpp.obj
[1580/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDebugify.cpp.obj
[1581/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPass.cpp.obj
[1582/3844] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunction.cpp.obj
[1583/3844] Building X86GenFastISel.inc...
[1584/3844] Building X86GenSubtargetInfo.inc...
[1585/3844] Building X86GenGlobalISel.inc...
[1586/3844] Building X86GenInstrInfo.inc...
[1587/3844] Building X86GenAsmMatcher.inc...
[1588/3844] Building X86GenDAGISel.inc...
[1589/3844] Building AMDGPUGenAsmWriter.inc...
[1590/3844] Building AMDGPUGenGlobalISel.inc...
[1591/3844] Building RISCVGenInstrInfo.inc...
[1592/3844] Building AMDGPUGenAsmMatcher.inc...
[1593/3844] Building RISCVGenGlobalISel.inc...
[1594/3844] Building AMDGPUGenInstrInfo.inc...
[1595/3844] Building AMDGPUGenDAGISel.inc...

```

https://github.com/llvm/llvm-project/pull/95369