[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:30:55 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-aarch64` running on `as-builder-2` while building `llvm` at step 7 "build-llvm-project".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/388

Here is the relevant piece of the build log for the reference:
```
Step 7 (build-llvm-project) failure: build (failure)
...
[1228/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBranchProbabilityInfo.cpp.obj
[1229/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InterleavedLoadCombinePass.cpp.obj
[1230/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LocalStackSlotAllocation.cpp.obj
[1231/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ExpandLargeFpConvert.cpp.obj
[1232/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveVariables.cpp.obj
[1233/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPrinterPass.cpp.obj
[1234/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ComplexDeinterleavingPass.cpp.obj
[1235/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCFGPrinter.cpp.obj
[1236/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveDebugVariables.cpp.obj
[1237/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.obj 
ccache C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-2\x-aarch64\build\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\build\include -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -external:IC:\buildbot\fs\zlib-win32\include -external:W0 -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen\MachinePostDominators.cpp
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1238/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.obj 
ccache C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-2\x-aarch64\build\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\build\include -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -external:IC:\buildbot\fs\zlib-win32\include -external:W0 -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen\MachineDomTreeUpdater.cpp
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1239/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCycleAnalysis.cpp.obj
[1240/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineLoopUtils.cpp.obj
[1241/4841] Building AArch64GenInstrInfo.inc...
[1242/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominanceFrontier.cpp.obj
[1243/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineModuleSlotTracker.cpp.obj
[1244/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFrameInfo.cpp.obj
[1245/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineLateInstrsCleanup.cpp.obj
[1246/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.obj 
ccache C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-2\x-aarch64\build\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\build\include -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -external:IC:\buildbot\fs\zlib-win32\include -external:W0 -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen\MachineBlockPlacement.cpp
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1247/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineOptimizationRemarkEmitter.cpp.obj
[1248/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSizeOpts.cpp.obj
[1249/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineRegionInfo.cpp.obj 
ccache C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1439~1.335\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-2\x-aarch64\build\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-2\x-aarch64\build\include -IC:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include -external:IC:\buildbot\fs\zlib-win32\include -external:W0 -D__OPTIMIZE__ /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\CodeGen\MachineRegionInfo.cpp
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1250/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineInstrBundle.cpp.obj
[1251/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCSE.cpp.obj
[1252/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MBFIWrapper.cpp.obj
[1253/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MIRYamlMapping.cpp.obj
[1254/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockFrequencyInfo.cpp.obj
[1255/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineModuleInfo.cpp.obj
[1256/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCheckDebugify.cpp.obj
[1257/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSSAContext.cpp.obj
[1258/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominators.cpp.obj
[1259/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCombiner.cpp.obj
[1260/4841] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegisterInfo.cpp.obj

```

https://github.com/llvm/llvm-project/pull/95369