[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:30:39 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/804

Here is the relevant piece of the build log for the reference:
```
Step 5 (compile-openmp) failure: build (failure)
...
40.993 [3165/32/995] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InlineSpiller.cpp.o
41.006 [3164/32/996] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBranchProbabilityInfo.cpp.o
41.058 [3163/32/997] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/InterleavedLoadCombinePass.cpp.o
43.303 [3162/32/998] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveIntervals.cpp.o
43.449 [3161/32/999] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LocalStackSlotAllocation.cpp.o
44.415 [3160/32/1000] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCFGPrinter.cpp.o
44.655 [3159/32/1001] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveVariables.cpp.o
44.708 [3158/32/1002] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPrinterPass.cpp.o
45.982 [3157/32/1003] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCombiner.cpp.o
46.031 [3156/32/1004] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/lib/CodeGen -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/include -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.o -c /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp
In file included from /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include/llvm/CodeGen/MachineDomTreeUpdater.h:21,
                 from /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen/MachineDomTreeUpdater.cpp:14:
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
46.464 [3156/31/1005] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFrameInfo.cpp.o
46.709 [3156/30/1006] Building AMDGPUGenAsmWriter.inc...
47.253 [3156/29/1007] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCheckDebugify.cpp.o
47.417 [3156/28/1008] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/lib/CodeGen -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/include -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.o -c /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen/MachineBlockPlacement.cpp
In file included from /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/lib/CodeGen/MachineBlockPlacement.cpp:44:
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include/llvm/CodeGen/MachinePostDominators.h:53:3: error: ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’ cannot be overloaded with ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   53 |   MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |   ^~~~~~~~~~~~~~~~~~~~~~~~
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/llvm/include/llvm/CodeGen/MachinePostDominators.h:51:12: note: previous declaration ‘llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction&)’
   51 |   explicit MachinePostDominatorTree(MachineFunction &MF) { recalculate(MF); }
      |            ^~~~~~~~~~~~~~~~~~~~~~~~
47.441 [3156/27/1009] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineInstrBundle.cpp.o
47.637 [3156/26/1010] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockFrequencyInfo.cpp.o
47.718 [3156/25/1011] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineConvergenceVerifier.cpp.o
48.163 [3156/24/1012] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDominanceFrontier.cpp.o
48.196 [3156/23/1013] Building AMDGPUGenGlobalISel.inc...
48.752 [3156/22/1014] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCycleAnalysis.cpp.o
48.760 [3156/21/1015] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCopyPropagation.cpp.o
48.820 [3156/20/1016] Building AMDGPUGenAsmMatcher.inc...
48.902 [3156/19/1017] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineCSE.cpp.o
49.115 [3156/18/1018] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/LiveDebugVariables.cpp.o
49.256 [3156/17/1019] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDebugify.cpp.o
49.554 [3156/16/1020] Building AMDGPUGenDAGISel.inc...
49.630 [3156/15/1021] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineFunctionPass.cpp.o
49.816 [3156/14/1022] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDominators.cpp.o
50.483 [3156/13/1023] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CodeGenPrepare.cpp.o
50.719 [3156/12/1024] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineLoopUtils.cpp.o

```

https://github.com/llvm/llvm-project/pull/95369