[llvm] [CodeGen] Introduce `MachineDomTreeUpdater` (PR #95369)

Wed Jun 26 21:30:01 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `llvm` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/936

Here is the relevant piece of the build log for the reference:
```
Step 6 (build-unified-tree) failure: build (failure)
...
[1240/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InterleavedAccessPass.cpp.obj
[1241/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InlineSpiller.cpp.obj
[1242/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveRegMatrix.cpp.obj
[1243/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBranchProbabilityInfo.cpp.obj
[1244/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ComplexDeinterleavingPass.cpp.obj
[1245/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\NonRelocatableStringpool.cpp.obj
[1246/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MIRPrinter.cpp.obj
[1247/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\InterleavedLoadCombinePass.cpp.obj
[1248/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveDebugVariables.cpp.obj
[1249/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineBlockPlacement.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockPlacement.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen\MachineBlockPlacement.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1250/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFunctionPrinterPass.cpp.obj
[1251/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LocalStackSlotAllocation.cpp.obj
[1252/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineDomTreeUpdater.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDomTreeUpdater.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen\MachineDomTreeUpdater.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1253/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePostDominators.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachinePostDominators.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen\MachinePostDominators.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1254/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineInstrBundle.cpp.obj
[1255/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCopyPropagation.cpp.obj
[1256/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCycleAnalysis.cpp.obj
[1257/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineFrameInfo.cpp.obj
[1258/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineDominanceFrontier.cpp.obj
[1259/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MIRYamlMapping.cpp.obj
[1260/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegisterInfo.cpp.obj
[1261/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineOptimizationRemarkEmitter.cpp.obj
[1262/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineModuleSlotTracker.cpp.obj
[1263/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineRegionInfo.cpp.obj 
C:\ninja\ccache.exe C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\build\include -IC:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2 /DNDEBUG -MD  /EHs-c- /GR- -std:c++17 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineRegionInfo.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\lib\CodeGen\MachineRegionInfo.cpp
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(53): error C2535: 'llvm::MachinePostDominatorTree::MachinePostDominatorTree(llvm::MachineFunction &)': member function already defined or declared
C:\buildbot\as-builder-3\llvm-clang-x86_64-win-fast\llvm-project\llvm\include\llvm/CodeGen/MachinePostDominators.h(51): note: see declaration of 'llvm::MachinePostDominatorTree::MachinePostDominatorTree'
[1264/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LiveVariables.cpp.obj
[1265/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineBlockFrequencyInfo.cpp.obj
[1266/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCFGPrinter.cpp.obj
[1267/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCheckDebugify.cpp.obj
[1268/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineLateInstrsCleanup.cpp.obj
[1269/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineModuleInfo.cpp.obj
[1270/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineLoopUtils.cpp.obj
[1271/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineCombiner.cpp.obj
[1272/3965] Building CXX object lib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MachineSink.cpp.obj

```

https://github.com/llvm/llvm-project/pull/95369