[llvm] [SmallPtrSet] Don't leave tombstones in small mode (PR #96762)

Jakub Kuderski via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 07:33:36 PDT 2024


================
@@ -352,7 +354,7 @@ class SmallPtrSetImpl : public SmallPtrSetImplBase {
   }
 
   /// erase - If the set contains the specified pointer, remove it and return
-  /// true, otherwise return false.
+  /// true, otherwise return false. Invalidates iterators if it returns true.
----------------
kuhar wrote:

nit: In the first line, the documentation doesn't really explain what this function does. Also, I'd remove the `erase - ` prefix -- not sure where this came from. 

https://github.com/llvm/llvm-project/pull/96762


More information about the llvm-commits mailing list