[llvm] [BOLT][AArch64] Fixes assertion errors occurred when perf2bolt was executed (PR #83394)

Ádám Kallai via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 01:29:49 PDT 2024


kaadam wrote:

> LGTM, but maybe handle nop+adr case in this patch? It shouldn't be difficult

Hi @yota9, Thanks for your comment. So You mean that to also detect 'nop' after adr instruction in 'analyzeIndirectBranchFragment' following this pattern below? Or are you thinking of a completely different pattern? 
```
  nop   => nop/adr instead of adrp/add
  adr     x13, 0x215a18 <_nl_value_type_LC_COLLATE+0x50>
  ldrh    w13, [x13, w12, uxtw #1]
  adr     x12, 0x247b30 <__gettextparse+0x5b0>
  add     x13, x12, w13, sxth #2
  br      x13 ```

https://github.com/llvm/llvm-project/pull/83394


More information about the llvm-commits mailing list