[llvm] [AMDGPU] Only reinitialize disassembler Bytes array when needed. NFC. (PR #96666)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 25 09:42:32 PDT 2024
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/96666
None
>From 08ddbfe99e91d9b56bf7e26f128baa3a6dc6052c Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Tue, 25 Jun 2024 17:41:16 +0100
Subject: [PATCH] [AMDGPU] Only reinitialize disassembler Bytes array when
needed. NFC.
---
.../AMDGPU/Disassembler/AMDGPUDisassembler.cpp | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
index 76a559c9443bd..0c0e9163fc6ef 100644
--- a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
+++ b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
@@ -494,10 +494,10 @@ DecodeStatus AMDGPUDisassembler::getInstruction(MCInst &MI, uint64_t &Size,
if (isGFX12() &&
tryDecodeInst(DecoderTableGFX12W6496, MI, DecW, Address, CS))
break;
- }
- // Reinitialize Bytes
- Bytes = Bytes_.slice(0, MaxInstBytesNum);
+ // Reinitialize Bytes
+ Bytes = Bytes_.slice(0, MaxInstBytesNum);
+ }
if (Bytes.size() >= 8) {
const uint64_t QW = eatBytes<uint64_t>(Bytes);
@@ -552,10 +552,10 @@ DecodeStatus AMDGPUDisassembler::getInstruction(MCInst &MI, uint64_t &Size,
if (isGFX12() &&
tryDecodeInst(DecoderTableGFX12W6464, MI, QW, Address, CS))
break;
- }
- // Reinitialize Bytes
- Bytes = Bytes_.slice(0, MaxInstBytesNum);
+ // Reinitialize Bytes
+ Bytes = Bytes_.slice(0, MaxInstBytesNum);
+ }
// Try decode 32-bit instruction
if (Bytes.size() >= 4) {
More information about the llvm-commits
mailing list