[llvm] d6c7410 - AMDGPU: Remove an outdated TODO (#96446)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 07:20:25 PDT 2024


Author: Nicolai Hähnle
Date: 2024-06-25T16:20:22+02:00
New Revision: d6c74102626ead8c4e2f7e638fdfea1fcd3d0bc7

URL: https://github.com/llvm/llvm-project/commit/d6c74102626ead8c4e2f7e638fdfea1fcd3d0bc7
DIFF: https://github.com/llvm/llvm-project/commit/d6c74102626ead8c4e2f7e638fdfea1fcd3d0bc7.diff

LOG: AMDGPU: Remove an outdated TODO (#96446)

We have a fixed calling convention for stack pointer and frame pointer,
we shouldn't try to shift anything around.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
index 072c5aedc220b..74f6fd64b473e 100644
--- a/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
@@ -83,7 +83,6 @@ SIMachineFunctionInfo::SIMachineFunctionInfo(const Function &F,
     if (CC != CallingConv::AMDGPU_Gfx)
       ArgInfo = AMDGPUArgumentUsageInfo::FixedABIFunctionInfo;
 
-    // TODO: Pick a high register, and shift down, similar to a kernel.
     FrameOffsetReg = AMDGPU::SGPR33;
     StackPtrOffsetReg = AMDGPU::SGPR32;
 


        


More information about the llvm-commits mailing list