[llvm] [MachO] Replace getStruct with getStructOrErr (PR #95810)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 05:24:20 PDT 2024


AtariDreams wrote:

> I repeat:
> 
> 
> 
> > Please don't force push to PRs, per the LLVM PR policy. If you need to rebase, you can use a merge commit to merge the latest changes into your PR branch. Using a force push trashes the review history, making it impossible to easily see what has changed from the previous version.
> 
> 
> 
> Also, commit messages like "ok", "f", and "h" are not helpful to reviewers. Please use meaningful comments in your intermediate comments, even if it's just something simple like "Address reviewer comments" or "fixed a minor bug" or whatever.
> 
> 
> 
> Ignoring reviewer requests will likely lead to people like me not dedicating the time necessary to review your code.

my bad for not marking this as draft as this wasn't meant for you to review at this time 

https://github.com/llvm/llvm-project/pull/95810


More information about the llvm-commits mailing list