[lld] [llvm] [ELF] Rename IsRela to HasAddend (PR #96592)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 25 01:12:54 PDT 2024


================
@@ -492,7 +492,7 @@ int64_t RelocationScanner::computeMipsAddend(const RelTy &rel, RelExpr expr,
 
   // The ABI says that the paired relocation is used only for REL.
   // See p. 4-17 at ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf
-  if (RelTy::IsRela)
+  if (RelTy::HasAddend)
----------------
smithp35 wrote:

Assuming MIPS will support CREL, but the ABI won't be updated to explicitly mention it, could be worth a small addition at the end.
```
The ABI says the paired relocation  is used only for REL.
  // See p. 4-17 at ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf this generalises to relocation types with implicit addends.
```

https://github.com/llvm/llvm-project/pull/96592


More information about the llvm-commits mailing list