[llvm] [DebugInfo] Swap 'Unit' and 'Type' positions in DISubprogram. (PR #96474)

[Jeremy Morse via llvm-commits]

jmorse wrote:

Most curious; my understanding of `Verifier::visitMDNode` [0] is that it should be calling out into visitDISubprogram by switching on the metadata ID -- do you have a reproducer for the behaviour you're observing? It sounds like something is broken, but if it's fixed by re-ordering fields then there's something even bigger that's broken lurking under the surface.

[0] https://github.com/llvm/llvm-project/blob/6481dc57612671ebe77fe9c34214fba94e1b3b27/llvm/lib/IR/Verifier.cpp#L1058

https://github.com/llvm/llvm-project/pull/96474