[llvm] [llvm-readobj][ELF] Implement JSON output for --dynamic-table (PR #95976)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 08:09:29 PDT 2024


jh7370 wrote:

> Sure thing. I'll make it happen. I am assuming just in this place.

As you've noticed yourself, it looks like the only case where there is a list is the RPATH/RUNPATH tags, so I guess take a look at `ListScope` occurrences in the relevant bit of code.

> > LGTM now, with a couple of nits. Just don't forget to update the commit message before merging.
> 
> Will do.
> 
> > Would you be okay to do a (hopefully) small follow-up change to tidy up the slightly weird LLVM output, where it is using lists for single-item elements, please?
> 
> Sure thing. I'll make it happen. I am assuming just in this place.

I'm thinking https://github.com/llvm/llvm-project/blob/db9e9eabb7835bae4285a3f13c7cc7c985455e27/llvm/tools/llvm-readobj/ELFDumper.cpp#L2474 is the area that needs changing for the LLVM-style output.

https://github.com/llvm/llvm-project/pull/95976


More information about the llvm-commits mailing list