[llvm] LoopInfo: introduce Loop::getLocStr; unify debug output (PR #93051)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 02:58:12 PDT 2024


fhahn wrote:

> > > > Can you add a test showing how the new debug info location is printed for new users?
> > > 
> > > 
> > > This is done in #93208.
> > 
> > 
> > But that's separate from this patch, right? Still would be good to have a test here to check the behavior of the patch, could also be in LAA
> 
> Not sure I follow. Isn't the debug location unstable (it's "stdin" or "filename" depending on whether the file was piped or if the file was passed in directly)?
> 
> I show the extra printed line in https://github.com/llvm/llvm-project/pull/93051/files#diff-691737e76443e1b38359d80e09fa9ad0cd14fd51ab4cc061d876604978fa4e2eR20-R21.

I might be missing something, but wouldn't this need a test with debug location for the loop? Then the output should be stable?

https://github.com/llvm/llvm-project/pull/93051


More information about the llvm-commits mailing list