[llvm] [SampleFDO] Stale profile call-graph matching (PR #95135)

via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 12:17:50 PDT 2024


================
@@ -189,7 +238,9 @@ LocToLocMap SampleProfileMatcher::longestCommonSequence(
         X = V[Index(K - 1)] + 1;
       Y = X - K;
       while (X < Size1 && Y < Size2 &&
-             AnchorList1[X].second == AnchorList2[Y].second)
+             functionMatchesProfile(AnchorList1[X].second,
----------------
WenleiHe wrote:

There is one problem with this -- we're treating similarity based fuzzy matching the same as the exact name matching, and that could lead to undesired result. Ideally, we should have exact matching (by name) done first, then fuzzy match the rest to produce profile name - function name pair. 

https://github.com/llvm/llvm-project/pull/95135


More information about the llvm-commits mailing list