[llvm] d462076 - [x86] Fix -Wunused-value in X86ISelLowering.cpp (NFC)

Jie Fu via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 15 06:25:41 PDT 2024


Author: Jie Fu
Date: 2024-06-15T21:24:46+08:00
New Revision: d46207645714620c95b2274a8a0996e5fcc24e92

URL: https://github.com/llvm/llvm-project/commit/d46207645714620c95b2274a8a0996e5fcc24e92
DIFF: https://github.com/llvm/llvm-project/commit/d46207645714620c95b2274a8a0996e5fcc24e92.diff

LOG: [x86] Fix -Wunused-value in X86ISelLowering.cpp (NFC)

llvm-project/llvm/lib/Target/X86/X86ISelLowering.cpp:28530:16:
error: left operand of comma operator has no effect [-Werror,-Wunused-value]
        return VT, DAG.getNode(ISD::OR, dl, VT, RLo, DAG.getBitcast(VT, RHi));
               ^~
1 error generated.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index c19a525df88ba..41dd4dc447bb1 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -28527,7 +28527,7 @@ static SDValue LowerMUL(SDValue Op, const X86Subtarget &Subtarget,
         RLo = DAG.getNode(ISD::AND, dl, VT, DAG.getBitcast(VT, RLo), Mask);
         RHi = DAG.getNode(X86ISD::VSHLI, dl, ExVT, RHi,
                           DAG.getTargetConstant(8, dl, MVT::i8));
-        return VT, DAG.getNode(ISD::OR, dl, VT, RLo, DAG.getBitcast(VT, RHi));
+        return DAG.getNode(ISD::OR, dl, VT, RLo, DAG.getBitcast(VT, RHi));
       }
     }
 


        


More information about the llvm-commits mailing list