[lld] [lld-macho][NFC] Track category merger input data source language for better verification (PR #95473)

Kyungwoo Lee via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 23:14:26 PDT 2024


================
@@ -1151,22 +1162,26 @@ void ObjcCategoryMerger::collectAndValidateCategoriesData() {
       if (nlCategories.count(categorySym))
         continue;
 
-      assert(categorySym->getName().starts_with(objc::symbol_names::category) ||
-             categorySym->getName().starts_with(
-                 objc::symbol_names::swift_objc_category));
-
       auto *catBodyIsec = dyn_cast<ConcatInputSection>(categorySym->isec());
       assert(catBodyIsec &&
              "Category data section is not an ConcatInputSection");
 
+      InfoInputCategory catInputInfo{catListCisec, catBodyIsec, off};
----------------
kyulee-com wrote:

Instead of allocating `catInputInfo` followed by setting `sourceLanguage`, can we construct `catInputInfo` once by passing the source language?

https://github.com/llvm/llvm-project/pull/95473


More information about the llvm-commits mailing list