[llvm] [llvm] terminate namespace with closing comment (PR #94917)

Mohammed Keyvanzadeh via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 18:40:11 PDT 2024


VoltrexKeyva wrote:

> @VoltrexKeyva it seems like you pushed a bunch of changes that shouldn't have ended up in this PR?
> 
> Also, please don't force push. It doesn't really matter in this case, but it breaks the location association for comments.

All changes are intentional, the formatting changes are to make the clang-format check happy due to its limitation as pointed out in https://github.com/llvm/llvm-project/pull/94917#issuecomment-2164305183

The force push is to update the branch with the latest commits in main using rebasing as there doesn't seem to be any other viable way without creating a merge commit. I haven't force pushed the relevant changes. Shall I do something else when trying to pull the latest changes?

https://github.com/llvm/llvm-project/pull/94917


More information about the llvm-commits mailing list