[llvm] Clang-format coroutine files ahead of refactoring (PR #95583)
Tyler Nowicki via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 14 14:28:15 PDT 2024
TylerNowicki wrote:
> Do you mind just do the refactoring that you are thinking of? You can format your change only without formatting entire files.
My thinking was that when moving code clang-format on the refactoring patches would result in code changes and maybe that is not great to do. Perhaps that is okay though, I am new to working on this so I will follow your advice.
btw, my intent is to make it easier for other users of llvm/transforms/coroutines (not just c++20). I'm sure you already noticed issues with the current design. To support swift it was necessary to add some code to the mid-level passes, but now all users will see and run the swift specific code. This will not scale as more users need specific behavior for things like spilling and remat. I plan to make some more significant changes that are likely not desirable for c++20 or swift. So to prepare for this I will refactor coroutines in a way that will make it possible for other users to use their own code without affecting the c++20 user.
https://github.com/llvm/llvm-project/pull/95583
More information about the llvm-commits
mailing list