[llvm] [libc++] Restart all preempted jobs (PR #95565)

[Louis Dionne via llvm-commits]

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/95565

Instead of only restarting preempted jobs when there was no other failure in the workflow, always restart preempted jobs. Doing otherwise leads to really confusing CI output since most of the failures are due to preempted workflows. One has to basically search for the job that failed "for real".

Instead, I think we should rely on the multiple CI stages to avoid running too many jobs when unnecessary, and we could also potentially cancel other running jobs whenever we find a failure. But the CI results should clearly indicate that such jobs were cancelled -- it shouldn't pretend that we had some failing jobs when they were only preempted.

>From 6be6a2054574b04001326b58459139213aec9979 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 14 Jun 2024 12:45:22 -0400
Subject: [PATCH] [libc++] Restart all preempted jobs

Instead of only restarting preempted jobs when there was no other failure
in the workflow, always restart preempted jobs. Doing otherwise leads to
really confusing CI output since most of the failures are due to preempted
workflows. One has to basically search for the job that failed "for real".

Instead, I think we should rely on the multiple CI stages to avoid running
too many jobs when unnecessary, and we could also potentially cancel other
running jobs whenever we find a failure. But the CI results should clearly
indicate that such jobs were cancelled -- it shouldn't pretend that we
had some failing jobs when they were only preempted.
---
 .../workflows/libcxx-restart-preempted-jobs.yaml   | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/.github/workflows/libcxx-restart-preempted-jobs.yaml b/.github/workflows/libcxx-restart-preempted-jobs.yaml
index 21879ce19c27c..0afa6709ebfa7 100644
--- a/.github/workflows/libcxx-restart-preempted-jobs.yaml
+++ b/.github/workflows/libcxx-restart-preempted-jobs.yaml
@@ -7,8 +7,6 @@ name: Restart Preempted Libc++ Workflow
 # We identify a canceled workflow run by checking the annotations of the check runs in the check suite,
 # which should contain the message "The runner has received a shutdown signal."
 
-# Note: If a job is both preempted and also contains a non-preemption failure, we do not restart the workflow.
-
 on:
   workflow_run:
     workflows: [Build and Test libc\+\+]
@@ -32,7 +30,6 @@ jobs:
         uses: actions/github-script at 60a0d83039c74a4aee543508d2ffcb1c3799cdea #v7.0.1
         with:
           script: |
-            const failure_regex = /Process completed with exit code 1./
             const preemption_regex = /The runner has received a shutdown signal/
 
             const wf_run = context.payload.workflow_run
@@ -103,17 +100,6 @@ jobs:
                   console.log('Found preemption message: ' + annotation.message);
                   has_preempted_job = true;
                 }
-
-                const failure_match = annotation.message.match(failure_regex);
-                if (failure_match != null) {
-                  // We only want to restart the workflow if all of the failures were due to preemption.
-                  // We don't want to restart the workflow if there were other failures.
-                  core.notice('Choosing not to rerun workflow because we found a non-preemption failure' +
-                    'Failure message: "' + annotation.message + '"');
-                  await create_check_run('skipped', 'Choosing not to rerun workflow because we found a non-preemption failure\n'
-                    + 'Failure message: ' + annotation.message)
-                  return;
-                }
               }
             }