[llvm] [CMAKE][llvm-libraries] Add Precompiled Headers option to improve build times (PR #91755)

Volodymyr Sapsai via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 18:55:36 PDT 2024


vsapsai wrote:

Sorry for not supporting your aspirations. I suggest to try getting an agreement on a smaller proposal and leave the rest for the future. I understand it's not what you'd like to have but bigger changes are riskier and people try to avoid risks, so it is harder to get an agreement on bigger changes.

I suggest to add precompiled headers as an opt-in option. So nothing changes for existing LLVM developers. But if anybody wants to try it, they can enable it. At this stage the community isn't responsible for maintaining the PCH configuration. If anything breaks, that's not grounds for a back-to-green revert. Someone (likely you) would work out with a breaking patch author what adjustments are required for PCH configuration to work again. Or maybe make the required tweaks yourself. As the future steps I consider
* Enabling PCH configuration in CI
* Enabling PCH configuration in Windows pre-commit job
* Enabling PCH configuration by default

If this proposal makes sense, we'll try to get more visibility on discourse and get buy-in from the rest of the community.

https://github.com/llvm/llvm-project/pull/91755


More information about the llvm-commits mailing list