[compiler-rt] Reland '[hwasan] Add fixed_shadow_base flag (#73980)' (PR #95445)
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 16:51:58 PDT 2024
vitalybuka wrote:
> Now also on the correct PR:
>
> I think that's incorrect:
>
> ```
> #ifndef SANITIZER_CAN_USE_PREINIT_ARRAY
> #if (SANITIZER_LINUX || SANITIZER_FUCHSIA || SANITIZER_NETBSD) && !defined(PIC)
> #define SANITIZER_CAN_USE_PREINIT_ARRAY 1
> // Before Solaris 11.4, .preinit_array is fully supported only with GNU ld.
> // FIXME: Check for those conditions.
> ```
>
> ANDROID is Linux and does in fact _support_ preinit array, we just don't use it for HWASan.
I believe it's disabled because hwasan is dynamic lib.
Either way this patch is correct for the current state of the code.
https://github.com/llvm/llvm-project/pull/95445
More information about the llvm-commits
mailing list