[lld] [llvm] [Symbolizer] Support for Missing Line Numbers. (PR #82240)

[via llvm-commits]

bd1976bris wrote:

@ampandey-1995 this might well be my failing but I'm afraid that I'm struggling to understand the tests. Before going on though I would like to say that I appreciate the effort you have put into them :) However, I don't understand why we would want to invoke the compiler and the linker (which is a complicated process to understand and results in input full of unnecessary features e.g. lots of crt symbols etc) rather than just hand coding the input? Furthermore, whilst I appreciate your use of the yaml2obj tool was suggested here, I don't think that the yaml input is very readable as it has large blocks of opaque hex. I also don't understand why we need two tests - can't we use one test for all the cases we need? I think that the names of the tests need to clearly describe to what they are testing (not how they are implemented e.g. "handcrafted") and the tests need comments describing what the test features and cases are.

I will *try* to post up an improved test if I can.

https://github.com/llvm/llvm-project/pull/82240