[llvm] [NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult (PR #95448)
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 11:16:33 PDT 2024
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/95448
After #94815, this is only used within ModuleToPostOrderCGSCCPassAdaptor::run(), so keep it local to that function.
>From d28055ea3e35c153ddfd2b69c1790164ed8376ab Mon Sep 17 00:00:00 2001
From: Arthur Eubanks <aeubanks at google.com>
Date: Thu, 13 Jun 2024 18:15:06 +0000
Subject: [PATCH] [NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult
After #94815, this is only used within ModuleToPostOrderCGSCCPassAdaptor::run(), so keep it local to that function.
---
llvm/include/llvm/Analysis/CGSCCPassManager.h | 11 -----------
llvm/lib/Analysis/CGSCCPassManager.cpp | 12 ++++++++----
2 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/llvm/include/llvm/Analysis/CGSCCPassManager.h b/llvm/include/llvm/Analysis/CGSCCPassManager.h
index b19d53621ac86..59974d146b56d 100644
--- a/llvm/include/llvm/Analysis/CGSCCPassManager.h
+++ b/llvm/include/llvm/Analysis/CGSCCPassManager.h
@@ -230,17 +230,6 @@ using ModuleAnalysisManagerCGSCCProxy =
/// Passes which do not change the call graph structure in any way can just
/// ignore this argument to their run method.
struct CGSCCUpdateResult {
- /// Worklist of the RefSCCs queued for processing.
- ///
- /// When a pass refines the graph and creates new RefSCCs or causes them to
- /// have a different shape or set of component SCCs it should add the RefSCCs
- /// to this worklist so that we visit them in the refined form.
- ///
- /// This worklist is in reverse post-order, as we pop off the back in order
- /// to observe RefSCCs in post-order. When adding RefSCCs, clients should add
- /// them in reverse post-order.
- SmallPriorityWorklist<LazyCallGraph::RefSCC *, 1> &RCWorklist;
-
/// Worklist of the SCCs queued for processing.
///
/// When a pass refines the graph and creates new SCCs or causes them to have
diff --git a/llvm/lib/Analysis/CGSCCPassManager.cpp b/llvm/lib/Analysis/CGSCCPassManager.cpp
index 2ed1d98f80068..24b3c6eef1084 100644
--- a/llvm/lib/Analysis/CGSCCPassManager.cpp
+++ b/llvm/lib/Analysis/CGSCCPassManager.cpp
@@ -160,10 +160,14 @@ ModuleToPostOrderCGSCCPassAdaptor::run(Module &M, ModuleAnalysisManager &AM) {
SmallVector<Function *, 4> DeadFunctions;
- CGSCCUpdateResult UR = {
- RCWorklist, CWorklist, InvalidRefSCCSet,
- InvalidSCCSet, nullptr, PreservedAnalyses::all(),
- InlinedInternalEdges, DeadFunctions, {}};
+ CGSCCUpdateResult UR = {CWorklist,
+ InvalidRefSCCSet,
+ InvalidSCCSet,
+ nullptr,
+ PreservedAnalyses::all(),
+ InlinedInternalEdges,
+ DeadFunctions,
+ {}};
// Request PassInstrumentation from analysis manager, will use it to run
// instrumenting callbacks for the passes later.
More information about the llvm-commits
mailing list