[llvm] [GISel][RISCV]Implement indirect parameter passing for large scalars (PR #95429)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 10:17:38 PDT 2024


================
@@ -764,19 +765,28 @@ bool CallLowering::handleAssignments(ValueHandler &Handler,
       // If we can't directly assign the register, we need one or more
       // intermediate values.
       Args[i].Regs.resize(NumParts);
-
-      // For each split register, create and assign a vreg that will store
-      // the incoming component of the larger value. These will later be
-      // merged to form the final vreg.
-      for (unsigned Part = 0; Part < NumParts; ++Part)
-        Args[i].Regs[Part] = MRI.createGenericVirtualRegister(NewLLT);
+    
+      // When we have indirect parameter passing we are receiving a pointer,
+      // that points to the actual value. In that case we need a pointer.
+      if (VA.getLocInfo() == CCValAssign::Indirect &&
+          Args[i].Flags[0].isSplit()) {
+        if (Handler.isIncomingArgumentHandler())
----------------
michaelmaitland wrote:

Why don't we need to handle the `!Handler.isIncomingArgumentHandler()` case? We handle both cases for non-indirect parameter passing.

https://github.com/llvm/llvm-project/pull/95429


More information about the llvm-commits mailing list