[llvm] [NVPTX] Add NVPTX intrinsics for TMA copies (PR #95289)
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 09:44:06 PDT 2024
joker-eph wrote:
I apologize if my comment looked like a strong objection here, that wasn't the intent. Also I'm used to comment on LLVM as a random contributor, just because of my current employment has no bearing on my comment (and in particular shouldn't carry more weight in the review here!). I'm neither in a position of approving or rejecting this PR.
@jlebar and @Artem-B should evaluate about what's reasonable for NVPTX in LLVM, the support of the NVVM IR spec, etc.
I just shared what I know about the NVVM IR spec, and squinting here it seemed to me that matching the metadata for kernel parameters and applying the same treatment you're already doing didn't seem out-of-reach (and would connect to the current MLIR emission of the general NVVM IR grid-constant metadata here: https://github.com/llvm/llvm-project/blob/main/mlir/test/Target/LLVMIR/nvvmir.mlir#L560-L575 ; which was added especially for TMA as well)
https://github.com/llvm/llvm-project/pull/95289
More information about the llvm-commits
mailing list