https://github.com/david-arm commented: I think the patch looks good and the tests are comprehensive! I just had a couple of minor comments, in particular the patch needs rebasing. Thanks! https://github.com/llvm/llvm-project/pull/89226