https://github.com/pogo59 approved this pull request. If you can, run the umask test on Windows, I'm pretty sure you want the change I marked. Otherwise LGTM. https://github.com/llvm/llvm-project/pull/94621