[llvm] [CodeGen] Preserve LiveStack analysis in StackSlotColoring pass (PR #94967)

[Matt Arsenault via llvm-commits]

================
@@ -534,6 +535,12 @@ bool StackSlotColoring::runOnMachineFunction(MachineFunction &MF) {
   InitializeSlots();
   Changed = ColorSlots(MF);
 
+  // Clear LiveStack analysis as it has been changed in ways that it requires
+  // efforts to rectify  which is equivalent to do it all over again. Also,
+  // this current results would not be used later, so better to clear it &
+  // preserve analysis.
+  LS->releaseMemory();
----------------
arsenm wrote:

If you're just going to throw away the result there's no point in claiming this is preserved, since it's a lie 

https://github.com/llvm/llvm-project/pull/94967