[llvm] [SPIRV] Fix warning in SPIRVMergeRegionExitTargets.cpp (PR #95283)

Helena Kotas via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 11:16:19 PDT 2024


https://github.com/hekota created https://github.com/llvm/llvm-project/pull/95283

Fix warning in SPIRVMergeRegionExitTargets.cpp about "non-void function does not return a value in all control paths" by changing assert to llvm_unreachable.

>From ce30d31e3f9cc472537daac6e848881b4af07c6f Mon Sep 17 00:00:00 2001
From: Helena Kotas <hekotas at microsoft.com>
Date: Wed, 12 Jun 2024 11:13:54 -0700
Subject: [PATCH] [SPIRV] Fix warning in SPIRVMergeRegionExitTargets.cpp

Change assert to llvm_unreachable
---
 llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp b/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
index 52354281cdd7e..0747dd1bbaf40 100644
--- a/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
@@ -100,7 +100,7 @@ class SPIRVMergeRegionExitTargets : public FunctionPass {
     }
 
     // TODO: add support for switch cases.
-    assert(false && "Unhandled terminator type.");
+    llvm_unreachable("Unhandled terminator type.");
   }
 
   /// Replaces |BB|'s branch targets present in |ToReplace| with |NewTarget|.



More information about the llvm-commits mailing list