[llvm] [GlobalISel][AArch64][AMDGPU] Lower FPOWI into series of multiplication (PR #95217)

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 10:15:36 PDT 2024


aemerson wrote:

> > > Where do you see this optimization?
> > 
> > 
> > It is in [SelectionDAGBuilder.cpp](https://github.com/isuckatcs/llvm-project/blob/2ca8c856eeae739ec1e7242ee7e69f99ecf376d3/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp#L5790)
> 
> Ugh, the DAG builder should definitely not be doing optimizations like this. But yes, this only works on constants and thus should not be a legalization strategy. It should be an optimization only in the CombinerHelper

+1 please move this to the combiner.

https://github.com/llvm/llvm-project/pull/95217


More information about the llvm-commits mailing list