[llvm] [test] Skip some tests on Windows only (PR #95205)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 01:34:01 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-debuginfo

Author: Jay Foad (jayfoad)

<details>
<summary>Changes</summary>

These tests do not require bash. Skip them because they use features not
available on Windows. This is a follow up to #<!-- -->94595.


---
Full diff: https://github.com/llvm/llvm-project/pull/95205.diff


3 Files Affected:

- (modified) llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test (+3-1) 
- (modified) llvm/test/Other/lit-unicode.txt (+2-2) 
- (modified) llvm/test/tools/llvm-rc/windres-prefix.test (+2-1) 


``````````diff
diff --git a/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test b/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
index 5141ff6ce322c..63c9f82bb0a63 100644
--- a/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
+++ b/llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test
@@ -1,4 +1,6 @@
-# REQUIRES: shell
+# This test uses symlinks.
+UNSUPPORTED: system-windows
+
 # Ensure that no realpath assumptions are made about .gnu_debuglink paths.
 
 # Copy inputs to some other location with arbitrary names, with the original
diff --git a/llvm/test/Other/lit-unicode.txt b/llvm/test/Other/lit-unicode.txt
index 2f40001451688..d884337d7cb2e 100644
--- a/llvm/test/Other/lit-unicode.txt
+++ b/llvm/test/Other/lit-unicode.txt
@@ -1,5 +1,5 @@
-FIXME: See if we can fix this in lit by using Unicode strings.
-REQUIRES: shell
+Windows echo does not have good Unicode support.
+UNSUPPORTED: system-windows
 
 RUN: echo "ようこそ" | FileCheck %s
 CHECK: {{^}}ようこそ{{$}}
diff --git a/llvm/test/tools/llvm-rc/windres-prefix.test b/llvm/test/tools/llvm-rc/windres-prefix.test
index 4c53fdfc3db65..a907666284704 100644
--- a/llvm/test/tools/llvm-rc/windres-prefix.test
+++ b/llvm/test/tools/llvm-rc/windres-prefix.test
@@ -1,4 +1,5 @@
-; REQUIRES: shell
+; This test uses symlinks.
+; UNSUPPORTED: system-windows
 
 ; RUN: rm -rf %t && mkdir %t
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/95205


More information about the llvm-commits mailing list