[llvm] [AMDGPU] Exclude certain opcodes from being marked as single use (PR #91802)

Ivan Kosarev via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 01:08:17 PDT 2024


================
@@ -819,9 +825,7 @@ class VOP3P_DPPe_Common<bits<7> op, VOPProfile P> : VOP3P_DPPe_Common_Base<op, P
 
 class VOP_DPP_Pseudo <string OpName, VOPProfile P, list<dag> pattern=[],
   dag Ins = P.InsDPP, string asmOps = P.AsmDPP> :
-  InstSI <P.OutsDPP, Ins, OpName#asmOps, pattern>,
-  VOP <OpName>,
-  SIMCInstr <OpName#"_dpp", SIEncodingFamily.NONE> {
+  VOP_Pseudo<OpName, "_dpp", P, P.OutsDPP, Ins, asmOps, pattern> {
----------------
kosarev wrote:

Looks reasonable to me and a refinement as well. I second Jay's words on whether it makes sense to limit the flags to `VOP_Pseudo`s and then have explicit `SIInstrInfo::isVAL()` checks, though.

https://github.com/llvm/llvm-project/pull/91802


More information about the llvm-commits mailing list