[llvm] [llvm][lit] Remove unused default feature (PR #94804)

Keith Smiley via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 11:10:55 PDT 2024


https://github.com/keith updated https://github.com/llvm/llvm-project/pull/94804

>From 3b2c41bf50c55c3fa0595084832b816996edc1e2 Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Fri, 7 Jun 2024 21:40:18 +0000
Subject: [PATCH 1/2] [llvm][lit] Remove unused default feature

It looks like this FIXME was resolved when the last use of this was
removed in 085f078307bac264301b07f6e47e2a04e90a6f1d
---
 llvm/utils/lit/lit/llvm/config.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index afb7f078072fc..30abb539d6647 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -88,14 +88,9 @@ def __init__(self, lit_config, config):
             ]
         )
 
-        # Running on Darwin OS
         if platform.system() == "Darwin":
-            # FIXME: lld uses the first, other projects use the second.
-            # We should standardize on the former.
-            features.add("system-linker-mach-o")
             features.add("system-darwin")
         elif platform.system() == "Windows":
-            # For tests that require Windows to run.
             features.add("system-windows")
         elif platform.system() == "Linux":
             features.add("system-linux")

>From f95df6fcc1989b74fba3cb6bd8a056d8a7803dd9 Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Tue, 11 Jun 2024 18:10:34 +0000
Subject: [PATCH 2/2] add comments back

---
 llvm/utils/lit/lit/llvm/config.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 30abb539d6647..7e3f39cc8682d 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -88,9 +88,11 @@ def __init__(self, lit_config, config):
             ]
         )
 
+        # Running on Darwin OS
         if platform.system() == "Darwin":
             features.add("system-darwin")
         elif platform.system() == "Windows":
+            # For tests that require Windows to run.
             features.add("system-windows")
         elif platform.system() == "Linux":
             features.add("system-linux")



More information about the llvm-commits mailing list