[llvm] [FPEnv][PowerPC] Correct one more strictfp test. (PR #94793)
Kevin P. Neal via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 11 06:19:07 PDT 2024
kpneal wrote:
See llvm/include/llvm/IR/Intrinsics.td where the constrained intrinsics are marked with, among others, the IntrStrictFP attribute. Because the constrained intrinsics are marked strictfp in the tablegen file there's no need to specify it again in test cases. It's redundant clutter. That's why I've been removing it from test cases that needed fixing anyway.
It sounds like `setflm readflm` need IntrStrictFP in their tablegen definition. That way we're sure that the attribute is never forgotten. Misuses of them outside of a strictfp function will also be rejected by D146845.
I found this particular test because I'm working on landing D146845. This IR Verifier change makes sure that strictfp is present on all function calls or callee definitions when used on the containing function's definition. If `setflm readflm` have IntrStrictFP added in their tablegen files then this Verifier change will always reject any use of them outside of a strictfp function.
https://github.com/llvm/llvm-project/pull/94793
More information about the llvm-commits
mailing list