[llvm] [test] Skip some tests on Windows only (PR #95095)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 02:53:32 PDT 2024


https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/95095

These tests pass on Linux using lit's internal shell.


>From 39163f5c0f9e6322987a8d80cc80899249a9c28e Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Tue, 11 Jun 2024 10:51:01 +0100
Subject: [PATCH] [test] Skip some tests on Windows only

These tests pass on Linux using lit's internal shell.
---
 llvm/test/DebugInfo/symbolize-gnu-debuglink-fallback.test | 2 +-
 llvm/test/tools/llvm-cov/gcov/basic.test                  | 2 +-
 llvm/test/tools/llvm-rc/windres-preproc.test              | 5 ++---
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/llvm/test/DebugInfo/symbolize-gnu-debuglink-fallback.test b/llvm/test/DebugInfo/symbolize-gnu-debuglink-fallback.test
index 43d5a2c818fac..c0d6f83e4af0d 100644
--- a/llvm/test/DebugInfo/symbolize-gnu-debuglink-fallback.test
+++ b/llvm/test/DebugInfo/symbolize-gnu-debuglink-fallback.test
@@ -1,4 +1,4 @@
-# REQUIRES: shell
+# UNSUPPORTED: system-windows
 # Ensures that .debuglink can fallback to a separate location. This is normally
 # /usr/lib/debug (or /usr/libdata/debug for NetBSD), but can be configured on
 # the command line (mainly for testing).
diff --git a/llvm/test/tools/llvm-cov/gcov/basic.test b/llvm/test/tools/llvm-cov/gcov/basic.test
index 5313fe2d7a69a..7557739add8ba 100644
--- a/llvm/test/tools/llvm-cov/gcov/basic.test
+++ b/llvm/test/tools/llvm-cov/gcov/basic.test
@@ -3,7 +3,7 @@
 
 # Test fails on Windows where internal shell is used due to path separator
 # mismatches.
-REQUIRES: shell
+UNSUPPORTED: system-windows
 
 RUN: rm -rf %t
 RUN: mkdir %t
diff --git a/llvm/test/tools/llvm-rc/windres-preproc.test b/llvm/test/tools/llvm-rc/windres-preproc.test
index 13f82299a074b..52427862e760b 100644
--- a/llvm/test/tools/llvm-rc/windres-preproc.test
+++ b/llvm/test/tools/llvm-rc/windres-preproc.test
@@ -1,7 +1,6 @@
 ;; Some quoted arguments below don't work properly on Windows when llvm-lit
-;; invokes the cmd shell to run the commands. Just require running in a
-;; posix shell, to keep being able to test this corner case on Unix at least.
-; REQUIRES: shell
+;; invokes the cmd shell to run the commands.
+; UNSUPPORTED: system-windows
 
 ; RUN: llvm-windres -### --include-dir %p/incdir1 --include %p/incdir2 "-DFOO1=\\\"foo bar\\\"" -UFOO2 -D FOO3 --preprocessor-arg "-DFOO4=\\\"baz baz\\\"" -DFOO5=\"bar\" %p/Inputs/empty.rc %t.res | FileCheck %s --check-prefix=CHECK1
 ; RUN: llvm-windres -### --include-dir %p/incdir1 --include %p/incdir2 "-DFOO1=\"foo bar\"" -UFOO2 -D FOO3 --preprocessor-arg "-DFOO4=\"baz baz\"" "-DFOO5=bar" %p/Inputs/empty.rc %t.res --use-temp-file | FileCheck %s --check-prefix=CHECK1



More information about the llvm-commits mailing list