[llvm] [BOLT][NFC] Add sink block to flow CFG in profile inference (PR #95047)

shaw young via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 16:03:17 PDT 2024


================
@@ -640,6 +663,9 @@ void assignProfile(BinaryFunction &BF,
       if (Jump->Flow == 0)
         continue;
 
+      // Skip the artificial sink block
----------------
shawbyoung wrote:

I'm not seeing where "BlockOrder.size() - 1" can be used. This check "if (Jump->Target == Func.Sink) continue;" ensures that the assertion within the index operation here "BinaryBasicBlock &SuccBB = *BlockOrder[Jump->Target - 1];" doesn't fail


https://github.com/llvm/llvm-project/pull/95047


More information about the llvm-commits mailing list