[llvm] [AMDGPU] MCExpr-ify AMDGPU HSAMetadata (PR #94788)
Scott Linder via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 10 15:57:30 PDT 2024
https://github.com/slinder1 commented:
Thank you for pushing this through more of the metadata handling! Sorry I haven't been super responsive, the patches are a bit dense and I have pushed off dedicated time to really look through them closely.
I still feel like I haven't been able to give every line due consideration, but in general it LGTM. I left a note about how some of the expressions are reaching a point of being only machine-readable, but I think I've made peace with the fact that some mistakes in asm just can't be diagnosed nicely.
https://github.com/llvm/llvm-project/pull/94788
More information about the llvm-commits
mailing list