[llvm] [BOLT][DWARF][NFC] Refactor RangeListsWritersByCU (PR #95008)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 09:54:16 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 338cbfef03e0ab58d7b52f3301928c58b194a1b4 997fff1bec96935882b03fa4de3565e07449e806 -- bolt/include/bolt/Rewrite/DWARFRewriter.h bolt/lib/Rewrite/DWARFRewriter.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h
index 91891cb28a..c9cc913d28 100644
--- a/bolt/include/bolt/Rewrite/DWARFRewriter.h
+++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h
@@ -82,7 +82,7 @@ private:
   using LocWriters = std::map<uint64_t, std::unique_ptr<DebugLocWriter>>;
   /// Use a separate location list writer for each compilation unit
   LocWriters LocListWritersByCU;
-  
+
   /// Stores and serializes information that will be put in to the
   /// .debug_rnglists DWARF section.
   /// Instance is created per DWO.
diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp
index 370ad19e1e..2996de125d 100644
--- a/bolt/lib/Rewrite/DWARFRewriter.cpp
+++ b/bolt/lib/Rewrite/DWARFRewriter.cpp
@@ -1870,8 +1870,7 @@ void DWARFRewriter::updateDWP(DWARFUnit &CU,
 
   DebugRangeListsSectionWriter *RangeListssWriter = nullptr;
   if (CU.getVersion() == 5) {
-    assert(RangeListsWriter &&
-           "No RangeListsWriter for DWO ID.");
+    assert(RangeListsWriter && "No RangeListsWriter for DWO ID.");
     RangeListssWriter = RangeListsWriter.get();
   }
   auto AddType = [&](unsigned int Index, uint32_t IndexVersion, uint64_t Offset,
@@ -2019,8 +2018,7 @@ void DWARFRewriter::writeDWOFiles(
 
   DebugRangeListsSectionWriter *RangeListssWriter = nullptr;
   if (CU.getVersion() == 5) {
-    assert(RangeListsWriter &&
-           "No RangeListsWriter for DWO ID.");
+    assert(RangeListsWriter && "No RangeListsWriter for DWO ID.");
     RangeListssWriter = RangeListsWriter.get();
 
     // Handling .debug_rnglists.dwo separately. The original .o/.dwo might not

``````````

</details>


https://github.com/llvm/llvm-project/pull/95008


More information about the llvm-commits mailing list