[llvm] goldsteinn/shift prop flags (PR #94872)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 8 13:19:11 PDT 2024
https://github.com/goldsteinn created https://github.com/llvm/llvm-project/pull/94872
- **[InstCombine] Add tests for propagating flags when folding consecutative shifts; NFC**
- **[InstCombine] Propagate flags when folding consecutative shifts**
>From 2ba7b7483a395f721d9db544a224ea7333f53393 Mon Sep 17 00:00:00 2001
From: Noah Goldstein <goldstein.w.n at gmail.com>
Date: Sat, 8 Jun 2024 15:16:37 -0500
Subject: [PATCH 1/2] [InstCombine] Add tests for propagating flags when
folding consecutative shifts; NFC
---
llvm/test/Transforms/InstCombine/shift.ll | 80 +++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/llvm/test/Transforms/InstCombine/shift.ll b/llvm/test/Transforms/InstCombine/shift.ll
index 8da52e0746373..8afce8780abd1 100644
--- a/llvm/test/Transforms/InstCombine/shift.ll
+++ b/llvm/test/Transforms/InstCombine/shift.ll
@@ -2240,4 +2240,84 @@ define i129 @shift_zext_not_nneg(i8 %arg) {
ret i129 %shl
}
+define i8 @src_shl_nsw(i8 %x) {
+; CHECK-LABEL: @src_shl_nsw(
+; CHECK-NEXT: [[R:%.*]] = shl i8 32, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = shl nsw i8 1, %x
+ %r = shl nsw i8 %sh, 5
+ ret i8 %r
+}
+
+define i8 @src_shl_nsw_fail(i8 %x) {
+; CHECK-LABEL: @src_shl_nsw_fail(
+; CHECK-NEXT: [[R:%.*]] = shl i8 32, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = shl nsw i8 1, %x
+ %r = shl i8 %sh, 5
+ ret i8 %r
+}
+
+define i8 @src_shl_nuw(i8 %x) {
+; CHECK-LABEL: @src_shl_nuw(
+; CHECK-NEXT: [[R:%.*]] = shl i8 12, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = shl nuw i8 3, %x
+ %r = shl nuw i8 %sh, 2
+ ret i8 %r
+}
+
+define i8 @src_shl_nuw_fail(i8 %x) {
+; CHECK-LABEL: @src_shl_nuw_fail(
+; CHECK-NEXT: [[R:%.*]] = shl i8 12, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = shl i8 3, %x
+ %r = shl nuw i8 %sh, 2
+ ret i8 %r
+}
+
+define i8 @src_lshr_exact(i8 %x) {
+; CHECK-LABEL: @src_lshr_exact(
+; CHECK-NEXT: [[R:%.*]] = lshr i8 48, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = lshr exact i8 96, %x
+ %r = lshr exact i8 %sh, 1
+ ret i8 %r
+}
+
+define i8 @src_lshr_exact_fail(i8 %x) {
+; CHECK-LABEL: @src_lshr_exact_fail(
+; CHECK-NEXT: [[R:%.*]] = lshr i8 48, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = lshr exact i8 96, %x
+ %r = lshr i8 %sh, 1
+ ret i8 %r
+}
+
+define i8 @src_ashr_exact(i8 %x) {
+; CHECK-LABEL: @src_ashr_exact(
+; CHECK-NEXT: [[R:%.*]] = lshr i8 8, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = ashr exact i8 32, %x
+ %r = ashr exact i8 %sh, 2
+ ret i8 %r
+}
+
+define i8 @src_ashr_exact_fail(i8 %x) {
+; CHECK-LABEL: @src_ashr_exact_fail(
+; CHECK-NEXT: [[R:%.*]] = lshr i8 8, [[X:%.*]]
+; CHECK-NEXT: ret i8 [[R]]
+;
+ %sh = ashr i8 32, %x
+ %r = ashr exact i8 %sh, 2
+ ret i8 %r
+}
+
declare i16 @llvm.umax.i16(i16, i16)
>From ca70abe53cf797dc2c5b4c33f388486d3e05c40e Mon Sep 17 00:00:00 2001
From: Noah Goldstein <goldstein.w.n at gmail.com>
Date: Sat, 8 Jun 2024 15:16:41 -0500
Subject: [PATCH 2/2] [InstCombine] Propagate flags when folding consecutative
shifts
When we fold `(shift (shift C0, x), C1)` we can propagate flags that
are common to both shifts.
Proofs: https://alive2.llvm.org/ce/z/LkEzXD
---
.../Transforms/InstCombine/InstCombineShifts.cpp | 15 ++++++++++++---
llvm/test/Transforms/InstCombine/shift.ll | 8 ++++----
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp b/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
index 9ff817da79368..4a014ab6e044e 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
@@ -767,11 +767,20 @@ Instruction *InstCombinerImpl::FoldShiftByConstant(Value *Op0, Constant *C1,
// (C2 >> X) >> C1 --> (C2 >> C1) >> X
Constant *C2;
Value *X;
- if (match(Op0, m_BinOp(I.getOpcode(), m_ImmConstant(C2), m_Value(X))))
- return BinaryOperator::Create(
+ bool IsLeftShift = I.getOpcode() == Instruction::Shl;
+ if (match(Op0, m_BinOp(I.getOpcode(), m_ImmConstant(C2), m_Value(X)))) {
+ Instruction *R = BinaryOperator::Create(
I.getOpcode(), Builder.CreateBinOp(I.getOpcode(), C2, C1), X);
+ BinaryOperator *BO0 = cast<BinaryOperator>(Op0);
+ if (IsLeftShift) {
+ R->setHasNoUnsignedWrap(I.hasNoUnsignedWrap() &&
+ BO0->hasNoUnsignedWrap());
+ R->setHasNoSignedWrap(I.hasNoSignedWrap() && BO0->hasNoSignedWrap());
+ } else
+ R->setIsExact(I.isExact() && BO0->isExact());
+ return R;
+ }
- bool IsLeftShift = I.getOpcode() == Instruction::Shl;
Type *Ty = I.getType();
unsigned TypeBits = Ty->getScalarSizeInBits();
diff --git a/llvm/test/Transforms/InstCombine/shift.ll b/llvm/test/Transforms/InstCombine/shift.ll
index 8afce8780abd1..03536f37fe762 100644
--- a/llvm/test/Transforms/InstCombine/shift.ll
+++ b/llvm/test/Transforms/InstCombine/shift.ll
@@ -2242,7 +2242,7 @@ define i129 @shift_zext_not_nneg(i8 %arg) {
define i8 @src_shl_nsw(i8 %x) {
; CHECK-LABEL: @src_shl_nsw(
-; CHECK-NEXT: [[R:%.*]] = shl i8 32, [[X:%.*]]
+; CHECK-NEXT: [[R:%.*]] = shl nsw i8 32, [[X:%.*]]
; CHECK-NEXT: ret i8 [[R]]
;
%sh = shl nsw i8 1, %x
@@ -2262,7 +2262,7 @@ define i8 @src_shl_nsw_fail(i8 %x) {
define i8 @src_shl_nuw(i8 %x) {
; CHECK-LABEL: @src_shl_nuw(
-; CHECK-NEXT: [[R:%.*]] = shl i8 12, [[X:%.*]]
+; CHECK-NEXT: [[R:%.*]] = shl nuw i8 12, [[X:%.*]]
; CHECK-NEXT: ret i8 [[R]]
;
%sh = shl nuw i8 3, %x
@@ -2282,7 +2282,7 @@ define i8 @src_shl_nuw_fail(i8 %x) {
define i8 @src_lshr_exact(i8 %x) {
; CHECK-LABEL: @src_lshr_exact(
-; CHECK-NEXT: [[R:%.*]] = lshr i8 48, [[X:%.*]]
+; CHECK-NEXT: [[R:%.*]] = lshr exact i8 48, [[X:%.*]]
; CHECK-NEXT: ret i8 [[R]]
;
%sh = lshr exact i8 96, %x
@@ -2302,7 +2302,7 @@ define i8 @src_lshr_exact_fail(i8 %x) {
define i8 @src_ashr_exact(i8 %x) {
; CHECK-LABEL: @src_ashr_exact(
-; CHECK-NEXT: [[R:%.*]] = lshr i8 8, [[X:%.*]]
+; CHECK-NEXT: [[R:%.*]] = lshr exact i8 8, [[X:%.*]]
; CHECK-NEXT: ret i8 [[R]]
;
%sh = ashr exact i8 32, %x
More information about the llvm-commits
mailing list