[llvm] Release note test v2 (PR #94774)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 7 10:36:09 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-github-workflow
Author: Tom Stellard (tstellar)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/94774.diff
4 Files Affected:
- (modified) .github/workflows/issue-write.yml (+1)
- (modified) .github/workflows/pr-request-release-note.yml (+8-2)
- (added) .github/workflows/temp ()
- (modified) llvm/utils/git/github-automation.py (+10-1)
``````````diff
diff --git a/.github/workflows/issue-write.yml b/.github/workflows/issue-write.yml
index e003be006c4e1..153734972e846 100644
--- a/.github/workflows/issue-write.yml
+++ b/.github/workflows/issue-write.yml
@@ -5,6 +5,7 @@ on:
workflows:
- "Check code formatting"
- "Check for private emails used in PRs"
+ - "PR Request Release Note"
types:
- completed
diff --git a/.github/workflows/pr-request-release-note.yml b/.github/workflows/pr-request-release-note.yml
index 5e48ce7aee2e2..cf7e7a431acad 100644
--- a/.github/workflows/pr-request-release-note.yml
+++ b/.github/workflows/pr-request-release-note.yml
@@ -2,7 +2,6 @@ name: PR Request Release Note
permissions:
contents: read
- pull-requests: write
on:
pull_request:
@@ -12,7 +11,6 @@ on:
jobs:
request-release-note:
if: >-
- github.repository_owner == 'llvm' &&
startsWith(github.ref, 'refs/heads/release')
runs-on: ubuntu-latest
@@ -41,3 +39,11 @@ jobs:
--token "$GITHUB_TOKEN" \
request-release-note \
--pr-number ${{ github.event.pull_request.number}}
+
+
+ - uses: actions/upload-artifact at 26f96dfa697d77e81fd5907df203aa23a56210a8 #v4.3.0
+ if: always()
+ with:
+ name: workflow-args
+ path: |
+ comments
diff --git a/.github/workflows/temp b/.github/workflows/temp
new file mode 100644
index 0000000000000..e69de29bb2d1d
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 1766ccb38ba25..46d05dab005c2 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -11,6 +11,7 @@
import argparse
from git import Repo # type: ignore
import html
+import json
import github
import os
import re
@@ -653,7 +654,15 @@ def request_release_note(token: str, repo_name: str, pr_number: int):
mention = f"@{submitter}"
comment = f"{mention} (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. "
- pr.as_issue().create_comment(comment)
+ try:
+ pr.as_issue().create_comment(comment)
+ except:
+ # Failed to create comment so emit file instead
+ with open("comments", "w") as file:
+ data = [
+ {"body" : comment}
+ ]
+ json.dump(data, file)
parser = argparse.ArgumentParser()
``````````
</details>
https://github.com/llvm/llvm-project/pull/94774
More information about the llvm-commits
mailing list