[llvm] [LVI] Generalize mask not equal conditions handling (PR #92946)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 7 03:25:23 PDT 2024


================
@@ -0,0 +1,91 @@
+; RUN: opt < %s -passes="jump-threading,print<lazy-value-info>" -disable-output 2>&1 | FileCheck %s
----------------
nikic wrote:

I prefer not to have `print<lazy-value-info>` tests. If you want to have better test coverage for this logic, I would recommend adding a `ConstantRange::makeMastNotEqualRange()` or so helper and then test it in ConstantRangeTest -- the big advantage is that you can add an exhaustive test and be certain that the logic is always correct.

https://github.com/llvm/llvm-project/pull/92946


More information about the llvm-commits mailing list