[llvm] [AMDGPU] Allocate i1 argument to SGPRs (PR #72461)
Jun Wang via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 6 14:57:37 PDT 2024
================
@@ -3741,6 +3741,19 @@ AMDGPURegisterBankInfo::getInstrMapping(const MachineInstr &MI) const {
if (!DstBank)
DstBank = SrcBank;
+ // For i1 function arguments, the call of getRegBank() currently gives
+ // incorrect result. We set both src and dst banks to VCCRegBank.
+ if (!MI.getOperand(1).getReg().isVirtual() &&
+ MRI.getType(MI.getOperand(0).getReg()) == LLT::scalar(1)) {
+ DstBank = SrcBank = &AMDGPU::VCCRegBank;
+ }
+
+ // For i1 return value, the dst reg is an SReg but we need to set the reg
+ // bank to VCCRegBank.
+ if (!MI.getOperand(0).getReg().isVirtual() &&
+ SrcBank == &AMDGPU::VCCRegBank)
+ DstBank = SrcBank;
+
----------------
jwanggit86 wrote:
Are you saying that the changes in `AMDGPURegisterBankInfo.cpp` should be a separate PR? Without those changes, I think some testcases will fail.
https://github.com/llvm/llvm-project/pull/72461
More information about the llvm-commits
mailing list